Stop skipping some Nexus tests on time skipping test server#1338
Open
Quinn-With-Two-Ns wants to merge 6 commits intomainfrom
Open
Stop skipping some Nexus tests on time skipping test server#1338Quinn-With-Two-Ns wants to merge 6 commits intomainfrom
Quinn-With-Two-Ns wants to merge 6 commits intomainfrom
Conversation
Quinn-With-Two-Ns
changed the title
Contributor
Author
|
A couple of cancel tests can't be enabled because of temporalio/sdk-java#2798 |
tconley1428
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop skipping some Nexus tests on time skipping test server. Nexus support on the time skipping server should work a lot better now so we can start running most tests. We are still skipping any test that uses the HTTP API since the time skipping server doesn't support that and some tests that use failure since the time skipping server doesn't support the new failure format yet.
Note
Low Risk
Test-only change that increases scenarios executed on the time-skipping test server; main risk is new CI flakiness or failures in environments where time-skipping still differs from standard execution.
Overview
Removes the
env.supports_time_skippingskip gate from multiple Nexus test cases so they now run under the time-skippingWorkflowEnvironment.This expands coverage for core Nexus behaviors (e.g., multi-invocation
USE_EXISTINGworkflow backing, basic sync/async operation paths, header propagation for@workflow_run_operation, service name routing, pre-workflow execution behavior, operation summaries, overload resolution, custom/buffered metrics, and cancellation-type semantics) without changing production code.Written by Cursor Bugbot for commit 9a5fa13. This will update automatically on new commits. Configure here.